Re: [PATCH 2/7] staging: wilc1000: Replace semaphore txq_add_to_head_cs with mutex

From: Arnd Bergmann
Date: Mon Jun 13 2016 - 09:19:48 EST


On Monday, June 13, 2016 4:07:34 PM CEST Binoy Jayan wrote:
> The semaphore 'txq_add_to_head_cs' is a simple mutex, so it should be
> written as one. Semaphores are going away in the future.

Looks good to me.

> Also, removing
> the timeout scenario as the error handling code does not propagate the
> timeout properly.

Good catch! I guess wilc_wlan_handle_txq() running into a timeout
would end putting the semaphore in a state in which we never again
block on it because the count is now one higher than it should be.

Arnd