Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

From: Laurent Pinchart
Date: Mon Jun 13 2016 - 08:17:42 EST


Hi Kieran,

Thank you for the patch.

On Thursday 09 Jun 2016 14:41:32 Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible
> processing.

With the comma dropped,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> Signed-off-by: Kieran Bingham <kieran@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt index
> 6a12960609d8..271dcfdb5a76 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the
> memory bandwidth.
>
> There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> they -are paired with. These DT bindings currently support the FCPV only.
> +are paired with. These DT bindings currently support the FCPV and FCPF.
>
> - compatible: Must be one or more of the following
>
> - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
> + - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for
> FDP' - "renesas,fcpv" for generic compatible 'FCP for VSP'
> + - "renesas,fcpf" for generic compatible 'FCP for FDP'
>
> When compatible with the generic version, nodes must list the
> SoC-specific version corresponding to the platform first, followed by
> the

--
Regards,

Laurent Pinchart