Re: [v1,4/4] drm/rockchip: cdn-dp: add cdn DP support for rk3399

[Chris Zhong]

Hi Guenter

Thanks for your comments

On 06/09/2016 06:13 AM, Guenter Roeck wrote:
> > +	if (ret < 0) {
> > >+		dev_err(dp->dev, "failed to request firmware %d\n", ret);
> > >+		return ret;
> > >+	}
> > >+
> > >+	hdr = (struct cdn_firmware_header *)fw->data;
> > >+	if (fw->size != le32_to_cpu(hdr->size_bytes))
> > >+		return -EINVAL;
> > >+
> > >+	ret = cdn_dp_clk_enable(dp);
> > >+	if (ret < 0) {
> > >+		dev_err(dp->dev, "cannot enable dp clk %d\n", ret);
> > >+		return ret;
> > >+	}
> > >+
> > >+	dp_clock_reset_seq(dp);
> > >+
> > >+	iram_data = (const u32 *)(fw->data + hdr->header_size);
> > >+	dram_data = (const u32 *)(fw->data + hdr->header_size + hdr->iram_size);
> No need for endianness conversion here ?
The firmware does need for endianness conversio.
And for the other comments, I have done them, v2 has been posted.