Re: [PATCH] dma: remove bad_dma_ops to fix build fail

From: Mark Brown
Date: Mon Jun 13 2016 - 05:29:53 EST


On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote:
> On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote:

> > config SND_SOC_CYGNUS
> > tristate "SoC platform audio for Broadcom Cygnus chips"
> > depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> > + depends on HAS_DMA
> > help
> > Say Y if you want to add support for ASoC audio on Broadcom
> > Cygnus chips (bcm958300, bcm958305, bcm911360)

> well, I have been doing the exact same thing for all the drivers that was
> failing to build but in my last patch Mark suggested to have stub
> implementation in the arch [1]. So while looking for that I noticed
> bad_dma_ops is not defined by anyone. So what will you suggest?

Right, we've got a couple of obscure architectures with no DMA support
which are leading to a constant stream of patches like this that are
being triggered by compile coverage stuff. In situations like this we
very often provide stubs rather than having to handle this in lots of
different places in the code.

Attachment: signature.asc
Description: PGP signature