Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time()

From: Arnd Bergmann
Date: Fri Jun 10 2016 - 18:23:21 EST


On Wednesday, June 8, 2016 10:04:45 PM CEST Deepa Dinamani wrote:
> CURRENT_TIME_SEC is not y2038 safe. current_fs_time() will
> be transitioned to use 64 bit time along with vfs in a
> separate patch.
> There is no plan to transistion CURRENT_TIME_SEC to use
> y2038 safe time interfaces.
>
> current_fs_time() will also be extended to use superblock
> range checking parameters when range checking is introduced.
>
> This works because alloc_super() fills in the the s_time_gran
> in super block to NSEC_PER_SEC.
>
> Also note that filesystem specific times like the birthtime,
> creation time that were using same interfaces to obtain time
> retain same logistics.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>

one question:

In an earlier version, you had a small optimization to
use ktime_get_real_seconds() instead of current_kernel_time()
when the granularity is seconds.

Do you still plan to send that one, or did you decide we don't
need it?

Arnd