Re: [PATCH 1/2] max8903: adds support for initiation via device tree.

From: Krzysztof Kozlowski
Date: Fri Jun 10 2016 - 02:13:36 EST


On 06/10/2016 07:35 AM, Chris Lapa wrote:
> Hi Krzysztof,
>
> Thanks for the review. I'm working on those changes now.
>
> However just so I know for the future. Why no error checking on
> devm_kzalloc() result? Looking through the source for devm_kzalloc() it
> looks like NULL isn't caught anywhere else.

Error checking is necessary. Just do not print the error message. The
kernel core will print one with full back trace.

if (charger == NULL)
return -ENOMEM;


Best regards,
Krzysztof