Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table

From: Sebastian Reichel
Date: Thu Jun 09 2016 - 21:29:43 EST


Hi,

On Tue, May 31, 2016 at 01:45:00PM -0500, Andrew F. Davis wrote:
> Currently for each device with a unique register map we have a named
> array that we then merge into a multidimensional array. Skip this
> middle step and apply the register arrays directly to the multi-array.

I applied the first two patches, but the third (this one) does not
compile for me:

CC [M] drivers/power/bq27xxx_battery.o
drivers/power/bq27xxx_battery.c:108:2: warning: braces around scalar initializer
[BQ27000] = {
^
drivers/power/bq27xxx_battery.c:108:2: note: (near initialization for âbq27xxx_regs[1]â)
drivers/power/bq27xxx_battery.c:109:4: error: array index in non-array initializer
[BQ27XXX_REG_CTRL] = 0x00,
^
drivers/power/bq27xxx_battery.c:109:4: note: (near initialization for âbq27xxx_regs[1]â)
drivers/power/bq27xxx_battery.c:110:4: error: array index in non-array initializer
[BQ27XXX_REG_TEMP] = 0x06,
^
...

-- Sebastian

Attachment: signature.asc
Description: PGP signature