Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled

From: Wolfram Sang
Date: Thu Jun 09 2016 - 16:47:16 EST



> The coherency is not dropped here. dma_map/unmap used
> makes the buffer coherent before passing it to
> dmaengine. Previously it was not required.
> I can add this in description if its not clear.

Please do.

>
> >> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >> }
> >> }
> >>
> >> + idx = 0;
> >> +
> >
> >This looks like an unrelated change.
> Ha, wrong. This should have been in a separate patch.

Exactly this is what I meant with "unrelated" :)

Attachment: signature.asc
Description: PGP signature