Re: Files leak from nfsd in 4.7.1-rc1 (and more?)

From: Andrew W Elble
Date: Thu Jun 09 2016 - 08:20:05 EST



> But...suppose we have two racing OPEN calls. They're both in
> nfs4_get_vfs_file. One opens the file and succeeds and the other fails
> and ends up in out_put_access. At that point, you could end up
> clobbering the successful update to st_access_bmap from the other task,
> and we'd end up not putting the file access references in
> release_all_access.


Pondering further (with an assumption about the workload), isn't this
path also likely to involve a lease break in progress on that file?

Thanks,

Andy

--
Andrew W. Elble
aweits@xxxxxxxxxxxxxxxxxx
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912