Re: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking

From: Thomas Gleixner
Date: Thu Jun 09 2016 - 05:03:46 EST


On Wed, 8 Jun 2016, David Kershner wrote:
> + /*
> + * If we're not paused, really enable interrupts.
> + * Regardless of whether we are paused, set a flag indicating
> + * interrupts should be enabled so when we resume, interrupts
> + * will really be enabled.
> + */
> + down_write(&devdata->lock_visor_dev);

I think I asked this before, but I might have missed the answer.

Why is this a rw_sempahore? It's never taken with down_read and looking at the
usage sites it's simply a mutex, right?

Thanks,

tglx