Re: [RFC PATCH 00/15] Exynos big-endian fixes

From: Ben Dooks
Date: Thu Jun 09 2016 - 04:09:57 EST


On 08/06/16 19:30, Matthew Leach wrote:
> Hi all,
>
> I've been working with Ben Dooks to get a big-endian kernel working on
> my Exynos 4412 board. Primarily this series consists of:
>
> - Replacing the __raw_{read,write}l accessors, which aren't
> endian-clean, with their respective {read,write}l_relaxed versions
> across various drivers.
>
> - Adding endian-aware {set,clear}_bit functions to the Exynos serial
> driver as the __{set,clear}_bit() functions aren't endian-clean.
>
> - Make the low-level Exynos debug printing macros endian-clean.
>
> There may well be other things that are broken under BE that we've not
> tested but this series should be enough to allow a board to boot
> user-space to a login prompt.

The only nit is the use of "be", it would be nicer to either use
BE8 consistently, or go for "big endian".

--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius