Re: [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

From: Naveen N. Rao
Date: Thu Jun 09 2016 - 02:09:35 EST


On 2016/06/08 10:19PM, Nilay Vaish wrote:
> Naveen, can you point out where in the patch you update the variable:
> idx, a member of codegen_contex structure? Somehow I am unable to
> figure it out. I can only see that we set it to 0 in the
> bpf_int_jit_compile function. Since all your test cases pass, I am
> clearly overlooking something.

Yes, that's being done in bpf_jit.h (see the earlier patches in the
series). All the PPC_*() instruction macros are defined to EMIT() the
respective powerpc instruction encoding. EMIT() translates to
PLANT_INSTR(), which actually increments idx.

- Naveen