Re: Regression in "kbuild: fix if_change and friends to consider argument order"

[Zanoni, Paulo R]

Em Ter, 2016-06-07 Ãs 23:52 +0200, Michal Marek escreveu:
> On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote:
> >Â
> 
> From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00
> 2001
> From: Michal Marek <mmarek@xxxxxxxx>
> Date: Tue, 7 Jun 2016 11:57:02 +0200
> Subject: [PATCH] kbuild: Initialize exported variables
> 
> The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to
> avoid duplicating its content when running make from within make
> (e.g.
> in the packaging targets). This became an issue after commit
> 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument
> order"), which no longer ignores the duplicate options. As Paulo
> Zanoni
> points out, the LDFLAGS_vmlinux variable has the same problem.
> 
> Reported-by: "Zanoni, Paulo R" <paulo.r.zanoni@xxxxxxxxx>
> Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider
> argument order")
> Signed-off-by: Michal Marek <mmarek@xxxxxxxx>

Works for me.

Tested-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>

Thanks a lot!

> ---
> ÂMakefile | 2 ++
> Â1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 0f70de63cfdb..af0c463e908f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -363,11 +363,13 @@ CHECK		= sparse
> Â
> ÂCHECKFLAGSÂÂÂÂÂ:= -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
> Â		ÂÂ-Wbitwise -Wno-return-void $(CF)
> +NOSTDINC_FLAGSÂÂ=
> ÂCFLAGS_MODULEÂÂÂ=
> ÂAFLAGS_MODULEÂÂÂ=
> ÂLDFLAGS_MODULEÂÂ=
> ÂCFLAGS_KERNEL	=
> ÂAFLAGS_KERNEL	=
> +LDFLAGS_vmlinux =
> ÂCFLAGS_GCOV	= -fprofile-arcs -ftest-coverage -fno-tree-loop-
> im -Wno-maybe-uninitialized
> ÂCFLAGS_KCOV	= -fsanitize-coverage=trace-pc
> Â