Re: [PATCH] Fix NFS option parsing bit-rot.

From: Trond Myklebust
Date: Wed Jun 08 2016 - 16:35:35 EST




On 6/8/16, 15:41, "Rob Landley" <rob@xxxxxxxxxxx> wrote:
>So addr= is at _best_ redundant. You MUST supply host:/ always,
>the current code just wasn't using it.

Thatâs because you just happen to be supplying an IP address instead of a hostname. The kernel has no DNS resolving functionality. It cannot resolve hostnames into IP addresses without help either by the caller or by means of an upcall. That is why âaddr=â has been a mandatory parameter ever since we introduced the text based parser.

Now we could, theoretically, have the client call nfs_dns_resolve_name() on the hostname to resolve it. However that breaks when you have net namespaces and such, since the kernelâs dns_query() call is not container aware.

Trond