Re: [PATCH 00/18] staging/android: clean up SW_SYNC

From: Gustavo Padovan
Date: Wed Jun 08 2016 - 15:08:11 EST


Hi Greg,

Any comment on this?

Gustavo

2016-05-31 Gustavo Padovan <gustavo@xxxxxxxxxxx>:

> From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
>
> Hi,
>
> The following patches do a clean up on the sw_sync inteface. It starts by
> removing struct sync_timeline_ops, which was creating unecessary wrappers
> in the code and the start to organize the sync_timeline and sw_sync code
> better.
>
> sw_sync interface was moved to sw_sync.c along with sync_timeline - which
> is now internal to sw_sync.
>
> The next step after this work is the actual de-stage of SW_SYNC and
> the upstreaming of selftests for sw_sync and sync_file.
>
> Please review!
>
> Gustavo
>
> ---
>
> Gustavo Padovan (18):
> staging/android: store last signaled value on sync timeline
> staging/android: remove .{fence,timeline}_value_str() from timeline_ops
> staging/android: remove struct sync_timeline_ops
> staging/android: remove sw_sync_timeline and sw_sync_pt
> staging/android: remove sw_sync.[ch] files
> staging/android: rename android_fence to timeline_fence
> staging/android: remove unnecessary check for fence
> staging/android: remove size arg of sync_timeline_create()
> staging/android: bring struct sync_pt back
> staging/android: move sw_sync related code to sw_sync.c
> staging/android: clean up #includes in the sync framework
> staging/android: make sync_timeline internal to sw_sync
> staging/android: make sw_ioctl info internal to sw_sync.c
> staging/android: remove 'destroyed' member from struct sync_timeline
> staging/android: remove sync_timeline_destroy()
> staging/android: remove drv_name from sync_timeline
> staging/android: rename sync.h to sync_debug.h
> staging/android: add DEBUG_FS dependence on Kconfig
>
> drivers/staging/android/Kconfig | 17 +-
> drivers/staging/android/Makefile | 3 +-
> drivers/staging/android/sw_sync.c | 341 ++++++++++++++++++++++++++++-----
> drivers/staging/android/sw_sync.h | 59 ------
> drivers/staging/android/sync.c | 221 ---------------------
> drivers/staging/android/sync.h | 154 ---------------
> drivers/staging/android/sync_debug.c | 154 +--------------
> drivers/staging/android/sync_debug.h | 83 ++++++++
> drivers/staging/android/trace/sync.h | 14 +-
> drivers/staging/android/uapi/sw_sync.h | 32 ----
> include/linux/fence.h | 2 -
> 11 files changed, 399 insertions(+), 681 deletions(-)
> delete mode 100644 drivers/staging/android/sw_sync.h
> delete mode 100644 drivers/staging/android/sync.c
> delete mode 100644 drivers/staging/android/sync.h
> create mode 100644 drivers/staging/android/sync_debug.h
> delete mode 100644 drivers/staging/android/uapi/sw_sync.h
>
> --
> 2.5.5
>