Re: [PATCH] hwmon: (tmp401) Add support for TI TMP461

From: Guenter Roeck
Date: Wed Jun 08 2016 - 13:44:00 EST


On Wed, Jun 08, 2016 at 11:56:29AM -0500, Andrew F. Davis wrote:

[ ... ]

> >> static const u8 TMP432_TEMP_MSB_READ[4][3] = {
> >> @@ -149,6 +156,7 @@ static const struct i2c_device_id tmp401_id[] = {
> >> { "tmp431", tmp431 },
> >> { "tmp432", tmp432 },
> >> { "tmp435", tmp435 },
> >> + { "tmp461", tmp461 },
> >
> > Please also provide code in the detect function to auto-detect the chip.
> >
>
> It looks like the ID reg has been removed (at least from the datasheet)
> so I'm not sure there is any good way to ID this part.
>
Outch :-(

Well, nothing we can do about that. Even if the register was there and provides
a value, it would be undocumented and thus unreliable and unusable. Too bad.

Thanks,
Guenter