Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers

From: Heiko Stübner
Date: Wed Jun 08 2016 - 08:27:12 EST


Am Mittwoch, 8. Juni 2016, 09:32:51 schrieb Tomeu Vizoso:
> When using DMA, the transfer_one callback should return 1 because the
> transfer hasn't finished yet.
>
> A previous commit changed the function to return 0 when the DMA channels
> were correctly prepared.
>
> This manifested in Veyron boards with this message:
>
> [ 1.983605] cros-ec-spi spi0.0: EC failed to respond in time
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> Fixes: ea9849113343 ("spi: rockchip: check return value of
> dmaengine_prep_slave_sg")
> Cc: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

looks like Mark already applied it, but nevertheless I was able to verify that
this patch fixes the issue on my veyron jerry chromebook as well, so

Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>