Re: [PATCH] gpio: 104-dio-48e: Fix control port offset computation off-by-one error

From: Linus Walleij
Date: Wed Jun 08 2016 - 04:08:48 EST


On Thu, Jun 2, 2016 at 10:00 PM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:

> There are only two control ports, each controlling three distinct I/O
> ports. To compute the control port address offset for a respective I/O
> port, the I/O port address offset should be divided by 3; dividing by 2
> may result in not only the wrong address offset but possibly also an
> out-of-bounds array memory access for a non-existent third control port.
>
> Fixes: 1b06d64f7374 ("gpio: Add GPIO support for the ACCES 104-DIO-48E")
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>

Patch applied.

Yours,
Linus Walleij