Re: [PATCH] rtlwifi: Change long delays to sleeps

From: Kalle Valo
Date: Sat Jun 04 2016 - 12:52:28 EST


Jan Kiszka <jan.kiszka@xxxxxx> writes:

> On 2016-02-15 23:12, Larry Finger wrote:
>> Routine rtl_addr_delay() uses delay statements in code that can
>> sleep. To improve system responsiveness, the various delay statements
>> are changed.
>>
>> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are
>> rewritten to use the code in rtl_addr_delay() for most of their
>> input values.
>>
>> Suggested-by: Byeoungwook Kim <quddnr145@xxxxxxxxx>
>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

[...]

> This breaks spectacularly when turning on a little bit of correctness
> checking:
>
> BUG: scheduling while atomic: wpa_supplicant/1116/0x00000002

This should fix it:

https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=de26859dcf363d520cc44e59f6dcaf20ebe0aadf

--
Kalle Valo