Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

From: Joe Perches
Date: Sat Jun 04 2016 - 12:29:15 EST


(adding acpi folks)

On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote:
> Both input and output code is simplified if we use a mapping from binary
> UUID index to ASCII UUID position.  This lets us combine hyphen-skipping
> and endian-swapping into one table.
>
> This significantly simplifies __uuid_to_bin(), which was using *two*
> lookup tables.

Seems sensible, thanks.

Trivially, acpi defines this but doesn't seem to use it.

include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /* Total length of a UUID string */

And Ingo commented last month:
https://lkml.org/lkml/2016/4/29/69

Maybe this __uuid_to_bin function should be made public and
the acpi version in drivers/acpi/acpica/utuuid.c should be
removed.