Re: [PATCH v8 13/14] perf callchain: Support x86 target platform

From: Jiri Olsa
Date: Thu Jun 02 2016 - 16:34:29 EST


On Thu, Jun 02, 2016 at 09:55:25AM +0000, He Kuang wrote:

SNIP

> @@ -31,9 +33,17 @@ int unwind__prepare_access(struct thread *thread, struct map *map)
> return 0;
>
> arch = normalize_arch(thread->mg->machine->env->arch);
> - pr_debug("unwind: target platform=%s\n", arch);
>
> - unwind__register_ops(thread, local_unwind_libunwind_ops);
> + if (!strcmp(arch, "x86"))
> + if (dso_type != DSO__TYPE_64BIT)
> + ops = x86_32_unwind_libunwind_ops;

pleas enclose above into { }

thanks,
jirka