Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Boris Brezillon]

Hi Ricard,

I was not in Cc of this series, so you're either developing an old
kernel version, or you didn't check the MAINTAINERS file (or didn't run
get_maintainer.pl on your series). And please, next time make sure
patches 1 to X are sent in replies to your cover letter.

On Thu, 2 Jun 2016 09:46:31 +0200
Ricard Wanderlof <ricard.wanderlof@xxxxxxxx> wrote:

> This patch set adds a driver and relevant devicetree bindings for the
> Evatronix NANDFLASH-CTRL NAND flash controller IP. This controller is
> used in the Axis ARTPEC-6 SoC.
> 
> The driver supports BCH ECC using the controller's hardware, but there is
> also an option to use software BCH ECC. However, the ECC layouts are not
> compatible so it's not possible to mix them. The main advantage to using
> software ECC is that there are more OOB bytes free, as the hardware is
> slightly wasteful on OOB space.
> 
> BCH ECC from 4 to 32 bits over 256, 512 or 1024 byte ECC blocks is supported.
> 
> Only large-page flash chips are supported, using 4 or 5 address cycles.
> 
> The driver has been extensively tested using hardware ECC on 2 Mbit flash chips,
> with 8 bit ECC over 512 bytes ECC blocks.

I'll to review the driver soon.

Regards,

Boris

> 
> Ricard Wanderlof (4):
>   of: Add device tree bindings for Evatronix NANDFLASH-CTRL
>   dts: Add Evatronix NAND flash driver to ARTPEC-6 dtsi
>   mtd: nand: Add support for Evatronix NANDFLASH-CTRL
>   MAINTAINERS: mtd: Add maintainer for Evatronix NAND flash driver
> 
>  .../devicetree/bindings/mtd/evatronix-nand.txt     |   44 +
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  MAINTAINERS                                        |    6 +
>  arch/arm/boot/dts/artpec6.dtsi                     |   19 +
>  drivers/mtd/nand/Kconfig                           |    6 +
>  drivers/mtd/nand/Makefile                          |    1 +
>  drivers/mtd/nand/evatronix_nand.c                  | 1909 ++++++++++++++++++++
>  7 files changed, 1986 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/evatronix-nand.txt
>  create mode 100644 drivers/mtd/nand/evatronix_nand.c
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com