Re: [PATCH 2/8] mwifiex: propagate sdio_enable_func() errno code in mwifiex_sdio_probe()

From: Julian Calaby
Date: Wed Jun 01 2016 - 00:15:42 EST


Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
<javier@xxxxxxxxxxxxxxx> wrote:
> If the sdio_enable_func() function fails on .probe, the -EIO errno code
> is always returned but that could make more difficult to debug and find
> the cause of why the function actually failed.
>
> Since the driver/device core prints the value returned by .probe in its
> error message propagate what was returned by sdio_enable_func() at fail.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

This looks sensible to me.

Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>

> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,

--
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/