Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

From: Lu Baolu
Date: Sun May 15 2016 - 21:00:38 EST


Hi,

On 05/13/2016 07:17 PM, Mark Brown wrote:
> On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote:
>
>> + gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
>> + if (IS_ERR(gpiod))
>> + return ERR_PTR(-ENODEV);
>> + config->gpio = desc_to_gpio(gpiod);
>> + config->enable_high = device_property_read_bool(dev,
>> + "enable-active-high");
>> + gpiod_put(gpiod);
> This isn't going to work at all if the GPIO is shared between multiple
> regulators but I can't immediately see a sensible way to fix that
> without some surgery on the GPIO APIs so let's leave it for now.

Okay. Thanks.

Best regards,
Lu Baolu