Re: [PATCH] sp5100_tco: properly check for new register layouts

From: Wim Van Sebroeck
Date: Sat May 14 2016 - 12:44:41 EST


Hi Lucas,

> Commits 190aa4304de6 (Add AMD Mullins platform support) and
> cca118fa2a0a94 (Add AMD Carrizo platform support) enabled the
> driver on a lot more devices, but the following commit missed
> a single location in the code when checking if the SB800 register
> offsets should be used. This leads to the wrong register being
> written which in turn causes ACPI to go haywire.
>
> Fix this by introducing a helper function to check for the new
> register layout and use this consistently.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=114201
> https://bugzilla.redhat.com/show_bug.cgi?id=1329910
> Fixes: bdecfcdb5461 (sp5100_tco: fix the device check for SB800
> and later chipsets)
> Cc: stable@xxxxxxxxxxxxxxx (4.5+)
> Signed-off-by: Lucas Stach <dev@xxxxxxxxxx>
> ---
> drivers/watchdog/sp5100_tco.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.