Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment.

From: Bjorn Helgaas
Date: Thu May 12 2016 - 08:08:44 EST


On Thu, May 12, 2016 at 12:50:07PM +0200, Tomasz Nowicki wrote:
> On 12.05.2016 00:43, Bjorn Helgaas wrote:

> >@@ -70,9 +71,11 @@ struct pci_config_window *pci_ecam_create(struct device *dev,
> > cfg->res.flags = IORESOURCE_MEM | IORESOURCE_BUSY;
> > cfg->res.name = "PCI ECAM";
> >
> >- err = request_resource(&iomem_resource, &cfg->res);
> >- if (err) {
> >- dev_err(dev, "request ECAM res %pR failed\n", &cfg->res);
> >+ conflict = request_resource(&iomem_resource, &cfg->res);
>
> We need request_resource_conflict here then:
> - conflict = request_resource(&iomem_resource, &cfg->res);
> + conflict = request_resource_conflict(&iomem_resource, &cfg->res);

Whoops, fixed, thanks!