Re: [PATCH v3] platform/chrome: Add Chrome OS keyboard backlight LEDs support

From: Olof Johansson
Date: Wed May 11 2016 - 15:00:34 EST


On Tue, Mar 08, 2016 at 11:12:46AM -0800, Dmitry Torokhov wrote:
> This is a driver for ACPI-based keyboard backlight LEDs found on
> Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
> backlight as "chromeos::kbd_backlight" LED class device in sysfs.
>
> Signed-off-by: Simon Que <sque@xxxxxxxxxxxx>
> Signed-off-by: Duncan Laurie <dlaurie@xxxxxxxxxxxx>
> Tested-by: Evan McClain <aeroevan@xxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxxxxxxx>
> ---
>
> Changes from previous submissions:
>
> v2->v3:
> - dropped call to platform_set_drvdata() as suggested by Guenter
>
> v1->v2:
> - moved from drivers/leds to drivers/platform/chrome
> - added method to retrieve brightness from ACPI
> - renamed to cros_kbd_led_backlight
> - config option renamed to CROS_KBD_LED_BACKLIGHT
> - no longer setting initial brightness to max brightness (although on
> Pixel 1 - Link - ACPI initially reports 100 as brightness anyway)

Ugh. I dropped the ball on this and other patches. Applied now.


-Olof