Re: [PATCH 6/6] pinctrl: tegra: Add driver to configure voltage and power state of io pads

From: Stephen Warren
Date: Wed May 11 2016 - 12:07:14 EST


On 05/11/2016 03:19 AM, Linus Walleij wrote:
On Mon, May 2, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

NVIDIA Tegra210 supports the IO pads which can operate at 1.8V
or 3.3V I/O voltage levels. Also the IO pads can be configured
for power down state if it is not used. SW needs to configure the
voltage level of IO pads based on IO rail voltage and its power
state based on platform usage.

The voltage and power state configurations of pads are provided
through pin control frameworks. Add pin control driver for Tegra's
IO pads' voltage and power state configurations.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

---
Changes from V1:
- Use the generic pincontrol property for low power enable/disable.
- sync with latest and remove all MODULE* macros
- Use renamed APIs form PMC

Looks OK to me, need Stephen's ACK though!

This driver is for HW that's separate from the main Tegra pinmux module. Thierry Reding and Jon Hunter are more appropriate reviewers for this one.