Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

From: Robert Foss
Date: Tue May 10 2016 - 13:19:52 EST


Thanks Eric!

On 2016-05-10 01:06 PM, Eric Anholt wrote:
Robert Foss <robert.foss@xxxxxxxxxxxxx> writes:

On 2016-05-03 03:22 PM, Eric Anholt wrote:
robert.foss@xxxxxxxxxxxxx writes:

From: Robert Foss <robert.foss@xxxxxxxxxxxxx>

As per the documentation in drm_crtc.h, atomic_commit should return
-EBUSY if an asycnhronous update is requested and there is an earlier
update pending.

Note: docs cited here are drm_crtc.h, and the whole quote is:

* - -EBUSY, if an asynchronous updated is requested and there is
* an earlier updated pending. Drivers are allowed to support a queue
* of outstanding updates, but currently no driver supports that.
* Note that drivers must wait for preceding updates to complete if a
* synchronous update is requested, they are not allowed to fail the
* commit in that case.

Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>

This looks good to me. Let's give it a few days on the list for any
other KMS folks to catch anything.


I haven't seen any further feedback regarding this patch.
Does anyone have objections to it being merged?

I merged it to drm-vc4-next last night, actually :)