Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed

From: Tomi Valkeinen
Date: Tue May 10 2016 - 06:53:17 EST


On 10/05/16 00:51, Arnd Bergmann wrote:
> In some configurations, we can build the OMAP dss driver without
> implictly including the pinctrl consumer definitions, causing
> a build error:
>
> gpu/drm/omapdrm/dss/dss.c: In function 'dss_runtime_suspend':
> gpu/drm/omapdrm/dss/dss.c:1268:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
>
> This adds an explicit #include.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/gpu/drm/omapdrm/dss/dss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index f95ff319e68e..3303cfad4838 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -30,6 +30,7 @@
> #include <linux/delay.h>
> #include <linux/seq_file.h>
> #include <linux/clk.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/gfp.h>

Thanks, queued for omapdrm fixes.

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature