Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently

From: Felipe Balbi
Date: Tue May 10 2016 - 06:15:37 EST



Hi,

Roger Quadros <rogerq@xxxxxx> writes:
>>>> Roger Quadros <rogerq@xxxxxx> writes:
>>>>> Don't make any decisions regarding VBUS session based on ID
>>>>> status. That is best left to the OTG core.
>>>>>
>>>>> Pass ID and VBUS events independent of each other so that OTG
>>>>> core knows exactly what to do.
>>>>>
>>>>> This makes dual-role with extcon work with OTG irq on OMAP platforms.
>>>>>
>>>>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>>>>
>>>> I have a feeling this will regress OMAP5432 uEVM. Did you test with that
>>>> board ?
>>>>
>>>
>>> Yes. Any specific test case you would like me to test?
>>> For now I'm just doing enumeration with g_zero.
>>
>> IIRC OMAP5 uEVM didn't have separate VBUS and ID GPIOs. How are you
>> handling that case ?
>>
> It comes from the PMIC, extcon-palmas.c.

alright, then :-)

--
balbi

Attachment: signature.asc
Description: PGP signature