Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

From: Felipe Balbi
Date: Tue May 10 2016 - 03:17:56 EST



Hi,

Brian Norris <briannorris@xxxxxxxxxxxx> writes:
> Hi William,
>
> Did you leave off linux-rockchip@xxxxxxxxxxxxxxxxxxx intentionally? IMO,
> it's nice to have that list in CC, so interested parties can follow your
> work, even if they aren't as fortunate as me to have been CC'd on your
> patch directly.
>
> On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
>> Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx>
>> ---
>> drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 9743353..1f3665b 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>> static const struct of_device_id of_dwc3_simple_match[] = {
>> { .compatible = "qcom,dwc3" },
>> { .compatible = "xlnx,zynqmp-dwc3" },
>> + { .compatible = "rockchip,dwc3" },
>
> Add to Documentation/devicetree/bindings/. Do we need a new
> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
> pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
> all bindings are documented in the common file?

dwc3.txt is for dwc3.ko. We need separate files for rockchip, xilinx and
qualcomn :-)

--
balbi

Attachment: signature.asc
Description: PGP signature