Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?

From: Radim KrÄmÃÅ
Date: Mon May 09 2016 - 10:47:24 EST


2016-05-09 16:00+0200, Paolo Bonzini:
> On 05/05/2016 10:24, Borislav Petkov wrote:
>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>>> When I run "make ARCH=x86 headers_install", and then write a simple C
>>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>>> compiler error: the BIT() macro used on line 219 of that file is
>>> undefined:
>>
>> The below patch should help...
>>
>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
>> stone?
>
> Unfortuntely it is cast in stone. The patch below is good though.

We can "fix" it by introducing a second name for the entry. Do you
think it's worth?

> Radim, please commit it
> (http://article.gmane.org/gmane.linux.kernel/2215443/raw) or pass the
> tree back to me so that I can. :)

I've committed the patch. The tree is yours now -- there probably is a
lot I missed ...