Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL

From: David Sterba
Date: Mon May 09 2016 - 03:32:31 EST


On Mon, May 09, 2016 at 09:11:53AM +0200, Jiri Slaby wrote:
> In ipwireless_get_serial_info, struct serial_struct is memset to 0 and
> then some members set to 0 explicitly.
>
> Remove the latter as it is obviously superfluous.
>
> And remove the retinfo check against NULL. copy_to_user will take care
> of that.
>
> Part of hub6 cleanup series.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: David Sterba <dsterba@xxxxxxxx>

Acked-by: David Sterba <dsterba@xxxxxxxx>