Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

From: tytso
Date: Thu May 05 2016 - 10:53:28 EST


On Thu, May 05, 2016 at 02:52:34PM +0200, Jan Kara wrote:
> On Fri 22-04-16 13:36:32, Seth Forshee wrote:
> > On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> > > A failed call to dqget() returns an ERR_PTR() and not null. Fix
> > > the check in ext4_ioctl_setproject() to handle this correctly.
> > >
> > > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> > > Cc: stable@xxxxxxxxxxxxxxx # v4.5
> > > Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> >
> > Thought I'd check and see if this patch was forgotten, I sent it nearly
> > a month ago but the bug is still present.
>
> Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Applied, thanks.

- Ted