Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount

From: Christoph Hellwig
Date: Thu May 05 2016 - 10:21:52 EST


> if (mp->m_flags & XFS_MOUNT_DAX) {
> + struct blk_dax_ctl dax = {
> + .sector = 0,
> + .size = PAGE_SIZE,
> + };

I'm pretty sure I already complained last week, but this boiler plate
code has no business in every file systems. Also it seems to me like
this struct blk_dax_ctl calling convention is stupid to start with,
why not pass the arguments directly and avoid the boilerplate code
everywhere?