Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()

From: Greg Kroah-Hartman
Date: Tue May 03 2016 - 17:19:30 EST


On Tue, May 03, 2016 at 10:53:05AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
> > In the original DWC3_DCFG_NUMP() was always zero. It looks like the
> > intent was to shift first and then do the mask.
> >
> > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculation of ACK TP NUMP')
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Thanks for this fix, I completely missed it :-) Greg, if you want to
> take this as a patch, that's fine by me. Otherwise I can queue it for
> -rc1. In any case, S-o-B below:
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxxxxxx>

I'll take it, thanks.

greg k-h