[PATCH] fix infoleak in llc

From: Kangjie Lu
Date: Tue May 03 2016 - 16:32:12 EST


The stack object âinfoâ has a total size of 12 bytes. Its last byte
is padding which is not initialized and leaked via âput_cmsgâ.

Signed-off-by: Kangjie Lu <kjlu@xxxxxxxxxx>
---
net/llc/af_llc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index b3c52e3..8ae3ed9 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr *msg, struct sk_buff *skb)
if (llc->cmsg_flags & LLC_CMSG_PKTINFO) {
struct llc_pktinfo info;

+ memset(&info, 0, sizeof(info));
info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex;
llc_pdu_decode_dsap(skb, &info.lpi_sap);
llc_pdu_decode_da(skb, info.lpi_mac);
--
1.9.1