Re: [PATCH v2] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs

From: Matt Fleming
Date: Tue May 03 2016 - 11:20:31 EST


On Mon, 02 May, at 03:11:20PM, Peter Jones wrote:
> On Sun, May 01, 2016 at 12:21:05AM +0800, Wang YanQing wrote:
> > We can't just break out when meet start is equal to zero,
> > this will cause we miss valid address range in later BARs.
> >
> > On the other hand, it isn't enough to test start only
> > for below situation:
> > 0(start) <= lfb_base < end
> >
> > Note: this patch also add a trivial optimization,
> > break out after we find the address range
> > is valid without test later BARs.
> >
> > Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
>
> This looks correct to me:
>
> Reviewed-By: Peter Jones <pjones@xxxxxxxxxx>
>
> Cc'ing Matt Fleming, since this should probably go through the EFI tree.

Applied, thanks.