Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module

From: Pavel Machek
Date: Sun May 01 2016 - 05:43:55 EST


Hi!

> Merge omap_ssi and omap_ssi_port into one module. This
> fixes problems with module cycle dependencies introduced
> by future patches.

Interesting way of saying that this prepares us for future patch
:-).


> +++ b/drivers/hsi/controllers/Makefile
> @@ -2,5 +2,5 @@
> # Makefile for HSI controllers drivers
> #
>
> -obj-$(CONFIG_OMAP_SSI) += omap_ssi.o
> -obj-$(CONFIG_OMAP_SSI_PORT) += omap_ssi_port.o
> +omap_ssi-objs += omap_ssi_core.o omap_ssi_port.o
> +obj-$(CONFIG_OMAP_SSI) += omap_ssi.o

Can you simply do

obj-$(CONFIG_OMAP_SSI) += omap_ssi_core.o omap_ssi_port.o

instead?

Thanks,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html