Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic

From: Sergey Senozhatsky
Date: Tue Apr 26 2016 - 20:32:45 EST


On (04/26/16 16:21), Petr Mladek wrote:
[..]
> > move printk_nmi_flush_on_panic() to printk.c, and place it next to
> > printk_flush_on_panic() (so we will have two printk "flush-on-panic"
> > functions sitting together). /* printk_nmi_flush() is in printk.h,
> > so it's visible to printk anyway */
> >
> > it also will let us keep logbuf_lock static, it's a bit too internal
> > to printk to expose it, I think.
> >
> > IOW, something like this?
>
> It is rather cosmetic change. I

oh yes, it is. just to keep similar functionality (flush, zap locks)
in one place (printk).

-ss