Re: [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback
From: Lee Jones
Date: Mon Apr 25 2016 - 12:23:29 EST
On Thu, 21 Apr 2016, Laxman Dewangan wrote:
> SMSC MFD driver does not add any MFD child devices via
> mfd_add_devices() and hence it is not required to call
> mfd_remove_devices() to remove MFD child devices.
>
> Remove the call of the API mfd_remove_devices() which will
> result as remove of .remove callback for driver.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Cc: Benoit Cousson <b-cousson@xxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx>
> ---
> This is build and compile tested only.
>
> drivers/mfd/smsc-ece1099.c | 10 ----------
> 1 file changed, 10 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
> index a4c0df7..7f89e89 100644
> --- a/drivers/mfd/smsc-ece1099.c
> +++ b/drivers/mfd/smsc-ece1099.c
> @@ -80,15 +80,6 @@ err:
> return ret;
> }
>
> -static int smsc_i2c_remove(struct i2c_client *i2c)
> -{
> - struct smsc *smsc = i2c_get_clientdata(i2c);
> -
> - mfd_remove_devices(smsc->dev);
> -
> - return 0;
> -}
> -
> static const struct i2c_device_id smsc_i2c_id[] = {
> { "smscece1099", 0},
> {},
> @@ -100,7 +91,6 @@ static struct i2c_driver smsc_i2c_driver = {
> .name = "smsc",
> },
> .probe = smsc_i2c_probe,
> - .remove = smsc_i2c_remove,
> .id_table = smsc_i2c_id,
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog