Re: [patch] Bluetooth: ath3k: Silence uninitialized variable warning

From: Dan Carpenter
Date: Sat Apr 23 2016 - 03:22:18 EST


On Sat, Apr 23, 2016 at 12:17:45PM +0530, Afzal Mohammed wrote:
> Hi,
>
> On Fri, Apr 22, 2016 at 01:02:55PM +0300, Dan Carpenter wrote:
>
> > - int err, pipe, len, size, count, sent = 0;
> > + int len = 0;
> > + int err, pipe, size, count, sent = 0;
>
> Is there any particular reason to avoid more than 1 variable
> initialization in definition on a single line ?, like,
>
> int err, pipe, size, count, sent = 0, len = 0;
>
> have observed that none of your uninitialized variable warning fixes
> does as mentioned above.

That sort of initialization is slightly less readable...

regards,
dan carpenter