Re: [PATCH V2 14/15] coresight: tmc: implementing TMC-ETR AUX space API

From: Suzuki K Poulose
Date: Thu Apr 21 2016 - 12:10:47 EST


On 12/04/16 18:54, Mathieu Poirier wrote:
This patch implement the AUX area interfaces required to
use the TMC (configured as an ETR) from the Perf sub-system.

The heuristic is heavily borrowed from the ETB10 and TMC-ETF
implementation.

Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>

+static void tmc_update_etr_buffer(struct coresight_device *csdev,
+ struct perf_output_handle *handle,
+ void *sink_config)
+{
+ struct cs_etr_buffers *buf = sink_config;
+
+ /*
+ * An ETR configured to work in contiguous memory mode works the same
+ * was as an ETB or ETF.
+ */
+ tmc_update_etf_buffer(csdev, handle, &buf->tmc);

Really ? I thought the ETR stores the data to the allocated System RAM and can
be read directly from the memory than using the RRD ?

Suzuki