Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

From: Rob Herring
Date: Thu Apr 21 2016 - 11:25:17 EST


On Tue, Apr 19, 2016 at 03:44:12PM +0200, Krzysztof Kozlowski wrote:
> Beside regular feed control interrupt, the driver requires also hash
> interrupt for older SoCs (samsung,s5pv210-secss). However after
> requesting it, the interrupt handler isn't doing anything with it, not
> even clearing the hash interrupt bit.
>
> Driver does not provide hash functions so it is safe to remove the hash
> interrupt related code and to not require the interrupt in Device Tree.

NAK for the DT change. If the h/w has a 2nd interrupt, then it should be
defined. Whether the driver uses it or not is a driver problem.

Rob