Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL client uncore

[Andi Kleen]

> Right. How about check the SKL_UNC_PERF_GLOBAL_CTL in enable_event?
> If it's cleared, we can reset it there. The drawback is that there will be an extra
> rdmsrl and a possible wrmsrl. 

It's better to not rely on register state for this. There are a variety
of user space tools that manipulate the uncore MSRs through /dev/*/msr
So better keep software state. Software state is also much faster than
reading MSRs.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only