RE: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC

[Qiang Zhao]

On 20/04/2016 12:22AM, Christophe Leroy <christophe.leroy@xxxxxx> wrote
> -----Original Message-----
> From: Christophe Leroy [mailto:christophe.leroy@xxxxxx]
> Sent: Wednesday, April 20, 2016 12:22 AM
> To: Qiang Zhao <qiang.zhao@xxxxxxx>; davem@xxxxxxxxxxxxx
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; Xiaobo Xie <xiaobo.xie@xxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; oss@xxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> akpm@xxxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC
> 
> Le 30/03/2016 10:50, Zhao Qiang a Ãcrit :
> > The driver add hdlc support for Freescale QUICC Engine.
> > It support NMSI and TSA mode.
> When using TSA, how does the TSA gets configured ? Especially how do you
> describe which Timeslot is switched to HDLC channels ?

the TSA is configured statically according to device tree node. 
For " which Timeslot is switched to HDLC channels ", there is a property 
"fsl,tx-timeslot-mask" in device tree to describe it.

> Is it possible to route some Timeslots to one UCC for HDLC, and route some
> others to another UCC for an ALSA sound driver ?

The feature you describe is not supported at present.

> The QE also have a QMC which allows to split all timeslots to a given UCC into
> independant channels that can either be used with HDLC or transparents (for
> audio for instance). Do you intent to also support QMC ?

new QE use UMCC instead of QMC in old QE, we have started to develop UMCC.
 
> According to the compatible property, it looks like your driver is for freescale
> T1040. The MPC83xx also has a Quick Engine, would it work on it too ?

The driver is common, but tested on t1040, it is needed to add node to MPC83xx
If you want to test on mpc83xx.

-Zhao Qiang