Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

From: David Miller
Date: Tue Apr 19 2016 - 20:15:56 EST


From: Andrew Goodbody <andrew.goodbody@xxxxxxxxxxxxxx>
Date: Mon, 18 Apr 2016 14:53:25 +0100

> This is a fix for a NULL pointer dereference from cpsw which is triggered
> by having two slave PHYs attached to a cpsw network device. The problem is
> due to only maintaining a single reference to a PHY node in the prive data
> which gets overwritten by the second PHY probe. So move the PHY node
> reference to the individual slave data so that there is now one per slave.
>
> v1 had a problem that data->slaves was used before it had been filled in

I already applied v1 the other day, so you need to send me a relative
patch rather than a whole new one.

Thanks.