Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast

From: Will Deacon
Date: Tue Apr 19 2016 - 09:46:20 EST


On Mon, Apr 18, 2016 at 10:12:33PM +0100, Matt Fleming wrote:
> On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> > memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> > causing a harmless warning:
> >
> > drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> > include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> > #define ULLONG_MAX (~0ULL)
> > ^
> > drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
> > memblock_remove(0, ULLONG_MAX);
> >
> > This adds an explicit typecast to avoid the warning
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> > ---
> > drivers/firmware/efi/arm-init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Will, this one is for you.
>
> Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>

Thanks, I'll throw it on the pile.

Will