Re: [PATCH v2] carl9170: Clarify kconfig text

[Christian Lamparter]

On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote:
> Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> writes:
> 
> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote:
> >> Lauri Kasanen <cand@xxxxxxx> writes:
> >> 
> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig
> >> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig
> >> > @@ -5,12 +5,10 @@ config CARL9170
> >> >  	select FW_LOADER
> >> >  	select CRC32
> >> >  	help
> >> > -	  This is another driver for the Atheros "otus" 802.11n USB devices.
> >> > +	  This is the mainline driver for the Atheros "otus" 802.11n USB devices.
> >> >  
> >> > -	  This driver provides more features than the original,
> >> > -	  but it needs a special firmware (carl9170-1.fw) to do that.
> >> > -
> >> > -	  The firmware can be downloaded from our wiki here:
> >> > +	  It needs a special firmware (carl9170-1.fw), which can be downloaded
> >> > +	  from our wiki here:
> >> >  	  <http://wireless.kernel.org/en/users/Drivers/carl9170>
> >> 
> >> Why even mention anything about a "special firmware" as the firmware is
> >> already available from linux-firmware.git? 
> >
> > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too
> > but that failed.
> > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639>
> 
> Rick's comment makes sense to me, better just to provide the latest
> version. No need to unnecessary confuse the users. And if someone really
> wants to use an older version that she can retrieve it from the git
> history.
Part of the fun here is that firmware is GPLv2. The linux-firmware.git has
to point to or add the firmware source to their tree. They have added every
single source file to it.... instead of "packaging" it in a tar.bz2/gz/xz
like you normally do for release sources.

If you want to read more about it:
<http://www.spinics.net/lists/linux-wireless/msg101868.html>